Bug 198875

Summary: [MediaStream] Avoid roundoff error when setting AVCapture min/max frame rate
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: WebRTCAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
youennf: review+
Patch for landing none

Eric Carlson
Reported 2019-06-14 17:40:23 PDT
Avoid roundoff error when setting AVCapture min/max frame rate
Attachments
Patch (5.01 KB, patch)
2019-06-14 19:06 PDT, Eric Carlson 		youennf: review+
DetailsFormatted DiffDiff
Patch for landing (4.97 KB, patch)
2019-06-15 19:45 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-06-14 17:40:33 PDT
<rdar://problem/51768374>
Eric Carlson
Comment 2 2019-06-14 19:06:26 PDT
Created attachment 372165 [details] Patch
youenn fablet
Comment 3 2019-06-15 18:39:18 PDT
Comment on attachment 372165 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=372165&action=review > Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:339 > + [device() setActiveVideoMaxFrameDuration: frameRateRange.maxFrameDuration]; Probably frameDuration instead of frameRateRange.maxFrameDuration.
Eric Carlson
Comment 4 2019-06-15 19:45:34 PDT
Created attachment 372211 [details] Patch for landing
Eric Carlson
Comment 5 2019-06-15 19:52:05 PDT
Comment on attachment 372165 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=372165&action=review >> Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:339 >> + [device() setActiveVideoMaxFrameDuration: frameRateRange.maxFrameDuration]; > > Probably frameDuration instead of frameRateRange.maxFrameDuration. Oops, I uploaded an old version of the patch :-/
WebKit Commit Bot
Comment 6 2019-06-16 18:38:57 PDT
Comment on attachment 372211 [details] Patch for landing Clearing flags on attachment: 372211 Committed r246489: <https://trac.webkit.org/changeset/246489>
Note You need to log in before you can comment on or make changes to this bug.