Summary: | Optimize `resolve` method lookup in Promise static methods | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexey Shvayka <ashvayka> | ||||||
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Minor | CC: | commit-queue, ews-watchlist, joepeck, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
URL: | https://github.com/tc39/ecma262/pull/1506 | ||||||||
Attachments: |
|
Description
Alexey Shvayka
2019-06-14 13:18:09 PDT
Created attachment 372138 [details]
Patch
Comment on attachment 372138 [details]
Patch
r=me
Comment on attachment 372138 [details] Patch Rejecting attachment 372138 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 372138, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=372138&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=198864&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Processing patch 372138 from bug 198864. Fetching: https://bugs.webkit.org/attachment.cgi?id=372138 Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Yusuke Suzuki']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 4 diffs from patch file(s). patching file JSTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file JSTests/test262/expectations.yaml Hunk #1 FAILED at 1080. Hunk #2 succeeded at 1110 (offset 18 lines). 1 out of 2 hunks FAILED -- saving rejects to file JSTests/test262/expectations.yaml.rej patching file Source/JavaScriptCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/JavaScriptCore/builtins/PromiseConstructor.js Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Yusuke Suzuki']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: https://webkit-queues.webkit.org/results/12523463 Created attachment 372496 [details]
Patch
Fix merge conflicts.
Nice! Comment on attachment 372496 [details]
Patch
r=me
Comment on attachment 372496 [details] Patch Clearing flags on attachment: 372496 Committed r246620: <https://trac.webkit.org/changeset/246620> All reviewed patches have been landed. Closing bug. |