Bug 198842

Summary: Move Synthetic Editing Commands to behind an experimental feature flag
Product: WebKit Reporter: Megan Gardner <megan_gardner>
Component: New BugsAssignee: Megan Gardner <megan_gardner>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, rniwa, simon.fraser, thorton, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch for landing none

Description Megan Gardner 2019-06-13 13:42:58 PDT 
Move Synthetic Editing Commands to behind an experimental feature flag
Comment 1 Megan Gardner 2019-06-13 13:48:01 PDT 
Created attachment 372077 [details]
Patch
Comment 2 Megan Gardner 2019-06-13 13:48:41 PDT 
<rdar://problem/50594700>
Comment 3 Simon Fraser (smfr) 2019-06-13 14:03:46 PDT 
Comment on attachment 372077 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372077&action=review

> Source/WebCore/page/RuntimeEnabledFeatures.h:188
> +    void setSyntheticEditingCommandsEnabled(bool isEnabled) { m_syntheticEditingCommandsEnabled = isEnabled; }
> +    bool syntheticEditingCommandsEnabled() const { return m_syntheticEditingCommandsEnabled; }

Should this be Setting instead?
Comment 4 Ryosuke Niwa 2019-06-13 14:04:47 PDT 
Comment on attachment 372077 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372077&action=review

>> Source/WebCore/page/RuntimeEnabledFeatures.h:188
>> +    bool syntheticEditingCommandsEnabled() const { return m_syntheticEditingCommandsEnabled; }
> 
> Should this be Setting instead?

Probably. There is no reason this needs to be enabled across the process.
Comment 5 Megan Gardner 2019-06-13 16:26:49 PDT 
Created attachment 372081 [details]
Patch
Comment 6 Simon Fraser (smfr) 2019-06-13 16:34:21 PDT 
Comment on attachment 372081 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372081&action=review

Now this is a setting, you can write tests for it (if we have the plumbing).

> Source/WebKitLegacy/mac/WebView/WebView.mm:3165
> +    RuntimeEnabledFeatures::sharedFeatures().setSyntheticEditingCommandsEnabled([preferences syntheticEditingCommandsEnabled]);

Nope!
Comment 7 Megan Gardner 2019-06-13 17:35:30 PDT 
Created attachment 372087 [details]
Patch
Comment 8 Megan Gardner 2019-06-14 13:17:37 PDT 
Created attachment 372137 [details]
Patch for landing
Comment 9 WebKit Commit Bot 2019-06-14 14:00:20 PDT 
Comment on attachment 372137 [details]
Patch for landing

Clearing flags on attachment: 372137

Committed r246444: <https://trac.webkit.org/changeset/246444>
Comment 10 WebKit Commit Bot 2019-06-14 14:00:21 PDT 
All reviewed patches have been landed.  Closing bug.