Bug 198835

Summary:

[iOS] Normalize test result of fast/events/ios/keyboard-event-key-attribute.html to handle possible modifier dispatch

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

Tools / Tests

Assignee:

Daniel Bates <dbates>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, darin, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

iPhone / iPad

OS:

iOS 12

Attachments:

Description	Flags
Patch	none

Description Daniel Bates 2019-06-13 10:16:58 PDT

In the future, modifier keys like Shift will be dispatched on iOS (just like they are on Mac). Prepare fast/events/ios/keyboard-event-key-attribute.html  for this future by normalizing its results. This test types '@' which requires holding down Shift to type on a US keyboard layout, but only expects to see a keydown for '@'. Currently, we only dispatch a keydown for the '@'. In the future, we will dispatch a keydown for Shift followed by a keydown for '@'.

Comment 1 Daniel Bates 2019-06-13 10:17:01 PDT

<rdar://problem/46082708>

Comment 2 Daniel Bates 2019-06-13 10:23:08 PDT

Created attachment 372065 [details]
Patch

Comment 3 Daniel Bates 2019-06-13 16:02:01 PDT

Comment on attachment 372065 [details]
Patch

Clearing flags on attachment: 372065

Committed r246417: <https://trac.webkit.org/changeset/246417>

Comment 4 Daniel Bates 2019-06-13 16:02:02 PDT

All reviewed patches have been landed.  Closing bug.