Bug 198832

Summary: twitch.tv: embedded video hovers down the screen when scrolling on iPad
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: ScrollingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ggaren, simon.fraser
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Antti Koivisto
Reported 2019-06-13 08:43:54 PDT
It does.
Attachments
patch (4.92 KB, patch)
2019-06-13 08:55 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2019-06-13 08:44:22 PDT
<rdar://problem/51541439>
Antti Koivisto
Comment 2 2019-06-13 08:55:23 PDT
Created attachment 372056 [details] patch
Geoffrey Garen
Comment 3 2019-06-13 10:50:41 PDT
Comment on attachment 372056 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=372056&action=review > Source/WebCore/rendering/RenderLayer.cpp:2522 > + if (auto* paintParent = paintOrderParent()) > + paintParent->setDescendantsNeedUpdateBackingAndHierarchyTraversal(); This might be a stupid question, but... In the case where paintParent is null, shouldn't we still setDescendantsNeedUpdateBackingAndHierarchyTraversal() on ourselves? auto* layer = paintOrderParent() ? paintOrderParent() : this; layer->setDescendantsNeedUpdateBackingAndHierarchyTraversal();
Antti Koivisto
Comment 4 2019-06-13 10:55:02 PDT
I believe that case is impossible and that if() is just being overly defensive.
Simon Fraser (smfr)
Comment 5 2019-06-13 10:58:14 PDT
Comment on attachment 372056 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=372056&action=review >> Source/WebCore/rendering/RenderLayer.cpp:2522 >> + paintParent->setDescendantsNeedUpdateBackingAndHierarchyTraversal(); > > This might be a stupid question, but... In the case where paintParent is null, shouldn't we still setDescendantsNeedUpdateBackingAndHierarchyTraversal() on ourselves? > > auto* layer = paintOrderParent() ? paintOrderParent() : this; > layer->setDescendantsNeedUpdateBackingAndHierarchyTraversal(); paintOrderParent() is only null for RenderView, so that should never hit this code.
WebKit Commit Bot
Comment 6 2019-06-13 11:36:09 PDT
Comment on attachment 372056 [details] patch Clearing flags on attachment: 372056 Committed r246407: <https://trac.webkit.org/changeset/246407>
WebKit Commit Bot
Comment 7 2019-06-13 11:36:10 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.