Summary: | REGRESSION (r246103) [ Mojave+ WK1 ] Layout Test scrollbars/scrollbar-iframe-click-does-not-blur-content.html is timing out | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Shawn Roberts <sroberts> | ||||
Component: | Tools / Tests | Assignee: | Antoine Quint <graouts> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | dino, graouts, thorton, webkit-bot-watchers-bugzilla, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=198462 | ||||||
Attachments: |
|
Description
Shawn Roberts
2019-06-12 13:14:35 PDT
Updated expectations in https://trac.webkit.org/changeset/246371/webkit We don't detect an NSScroller in a sub-frame due to the WebHTMLView's implementation of -[NSView hitTest:]. We need to use the real method when detecting which view we're trying to swizzle the event for. Created attachment 372042 [details]
Patch
Comment on attachment 372042 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=372042&action=review > Tools/ChangeLog:10 > + which lets use use the default implementation and correctly returns an NSScroller in a sub-frame. use use > Tools/DumpRenderTree/mac/EventSendingController.mm:570 > + view = [(WebHTMLView*)view _hitViewForEvent:event]; WebHTMLView * Committed r246429: <https://trac.webkit.org/changeset/246429> |