Bug 198785

Summary: [GTK] gtk_misc_set_alignment is deprecated since GTK 3.14
Product: WebKit Reporter: Ludovico de Nittis <ludovico.denittis>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, bugs-noreply, cgarcia, commit-queue, ews-watchlist, gustavo, mcatanzaro
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Ludovico de Nittis
Reported 2019-06-12 06:14:18 PDT
Since GTK 3.14 "gtk_misc_set_alignment" has been deprecated. "gtk_widget_set_halign" and "gtk_widget_set_valign" should be used instead, both available since GTK 3. I'll attach a patch.
Attachments
Patch (1.65 KB, patch)
2019-06-12 06:16 PDT, Ludovico de Nittis 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ludovico de Nittis
Comment 1 2019-06-12 06:16:42 PDT
Created attachment 371947 [details] Patch
EWS Watchlist
Comment 2 2019-06-12 06:19:14 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
WebKit Commit Bot
Comment 3 2019-06-12 07:09:15 PDT
Comment on attachment 371947 [details] Patch Clearing flags on attachment: 371947 Committed r246351: <https://trac.webkit.org/changeset/246351>
WebKit Commit Bot
Comment 4 2019-06-12 07:09:17 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.