Summary: | [WHLSL] Code that accesses an undefined variable crashes | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Saam Barati <saam> | ||||||
Component: | WebGPU | Assignee: | Saam Barati <saam> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, dino, fpizlo, jonlee, justin_fan, mmaxfield, rmorisset, webkit-bug-importer | ||||||
Priority: | P1 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Saam Barati
2019-06-11 18:09:41 PDT
Crashes in the Checker working on this next Created attachment 372593 [details]
patch
Comment on attachment 372593 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=372593&action=review > LayoutTests/webgpu/whlsl-use-undefined-variable.html:18 > +async function start() { Where are the -expected.txts? Comment on attachment 372593 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=372593&action=review > LayoutTests/ChangeLog:11 > + Myles mostly fixed this in r246631 when he made NameResolver propagate > + its error to its parent NameResolver. However, there was still one bug > + where we ended up calling setError twice for an if statement. This patch > + fixes that and adds tests. OOPS, This should go in WebCore's changelog Created attachment 372651 [details]
patch for landing
Comment on attachment 372651 [details] patch for landing Clearing flags on attachment: 372651 Committed r246700: <https://trac.webkit.org/changeset/246700> All reviewed patches have been landed. Closing bug. |