Bug 198769

Summary:

Flash when tapping compose button after switching to/from dark mode without restarting Mail

Product:

WebKit

Reporter:

Timothy Hatcher <timothy>

Component:

WebKit Misc.

Assignee:

Timothy Hatcher <timothy>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, megan_gardner, thorton, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Timothy Hatcher

Reported 2019-06-11 15:54:22 PDT

After switching to/from dark mode and the compose button is tapped in Mail, there is a white flash which can be seen consistently. <rdar://problem/51370037>

Attachments
Patch (2.56 KB, patch) 2019-06-11 16:03 PDT, Timothy Hatcher	no flags	Details Formatted Diff Diff
Patch (4.98 KB, patch) 2019-06-11 16:21 PDT, Timothy Hatcher	no flags	Details Formatted Diff Diff
Patch (4.97 KB, patch) 2019-06-11 16:22 PDT, Timothy Hatcher	no flags	Details Formatted Diff Diff
Patch (4.98 KB, patch) 2019-06-11 16:34 PDT, Timothy Hatcher	no flags	Details Formatted Diff Diff
Patch (4.98 KB, patch) 2019-06-11 16:43 PDT, Timothy Hatcher	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Timothy Hatcher

Comment 1 2019-06-11 16:03:54 PDT Comment hidden (obsolete)

Created attachment 371889 [details] Patch

Tim Horton

Comment 2 2019-06-11 16:07:36 PDT

Comment on attachment 371889 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371889&action=review > Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:144 > +#import "LocalCurrentTraitCollection.h" iOS API Test EWS doesn't seem to find this.... is it in WebCore?

Timothy Hatcher

Comment 3 2019-06-11 16:18:00 PDT

Comment on attachment 371889 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371889&action=review >> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:144 >> +#import "LocalCurrentTraitCollection.h" > > iOS API Test EWS doesn't seem to find this.... is it in WebCore? Yep… it is in WebCore now. I buggered change this when I moved it from WebKitAdditions. It built locally somehow… maybe some stale version in my search path? Will fix.

Timothy Hatcher

Comment 4 2019-06-11 16:21:07 PDT Comment hidden (obsolete)

Created attachment 371891 [details] Patch

Timothy Hatcher

Comment 5 2019-06-11 16:22:08 PDT Comment hidden (obsolete)

Created attachment 371892 [details] Patch

Timothy Hatcher

Comment 6 2019-06-11 16:34:34 PDT Comment hidden (obsolete)

Created attachment 371893 [details] Patch

Timothy Hatcher

Comment 7 2019-06-11 16:43:09 PDT

Created attachment 371897 [details] Patch