Bug 198768

Summary: [iOS] Adjust test fast/events/ios/keyup.html to ignore Shift keyups
Product: WebKit Reporter: Daniel Bates <dbates>
Component: Tools / TestsAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, webkit-bug-importer, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: All   
OS: iOS 12   
Attachments:
Description Flags
Patch
none
To land none

Daniel Bates
Reported 2019-06-11 15:11:47 PDT
In the future WebKit will receive flag changes (e.g. the Shift key was pressed). When this happens the test fast/events/ios/keyup.html will fail due to additional Shift keyup events. Fix up the test to ignore Shift keyups. We have other tests that cover the Shift keyups that will be enabled in the future.
Attachments
Patch (2.02 KB, patch)
2019-06-11 15:13 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
To land (2.02 KB, patch)
2019-06-11 16:00 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2019-06-11 15:12:01 PDT
<rdar://problem/46082743>
Daniel Bates
Comment 2 2019-06-11 15:13:47 PDT
Created attachment 371885 [details] Patch
Brent Fulgham
Comment 3 2019-06-11 15:56:13 PDT
Comment on attachment 371885 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371885&action=review > LayoutTests/ChangeLog:10 > + currently skipped in OpenSource that will be unskipped in the future once UIKit support is available. Is there a radar we can reference for the UIKit update?
Daniel Bates
Comment 4 2019-06-11 15:59:31 PDT
(In reply to Brent Fulgham from comment #3) > Comment on attachment 371885 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=371885&action=review > > > LayoutTests/ChangeLog:10 > > + currently skipped in OpenSource that will be unskipped in the future once UIKit support is available. > > Is there a radar we can reference for the UIKit update? It would take me time to track them down and there is likely more than one. Short answer once we start building with ENABLE(FULL_KEYBOARD_ACCESS) in OpenSource then the time will be right to unkip many tests. Will update ChangeLog before landing.
Daniel Bates
Comment 5 2019-06-11 16:00:35 PDT
Created attachment 371888 [details] To land
Daniel Bates
Comment 6 2019-06-11 16:01:04 PDT
Committed r246338: <https://trac.webkit.org/changeset/246338>
Note You need to log in before you can comment on or make changes to this bug.