Summary: | Integrate scrollbar gestures for iOS | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Megan Gardner <megan_gardner> | ||||||
Component: | New Bugs | Assignee: | Megan Gardner <megan_gardner> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, thorton, timothy, webkit-bug-importer, wenson_hsieh | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Megan Gardner
2019-06-11 14:12:11 PDT
Created attachment 371878 [details]
Patch
Comment on attachment 371878 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371878&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:1758 > +static BOOL _WKGestureRecognizerIsBuiltInScrollViewGestureRecognizer(UIGestureRecognizer *recognizer) Nit - isBuiltInScrollViewGestureRecognizer()? We typically only put a WK or _WK prefix on API or SPI. Comment on attachment 371878 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371878&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:1758 > +static BOOL _WKGestureRecognizerIsBuiltInScrollViewGestureRecognizer(UIGestureRecognizer *recognizer) drop the _WK. Probably just "isBuiltInScrollViewGestureRecognizer", even. > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:1771 > + BOOL conflictsWithBuiltInGesture = _WKGestureRecognizerIsBuiltInScrollViewGestureRecognizer(preventedGestureRecognizer); I don't think "conflictsWith" is the right phrasing? Created attachment 371883 [details]
Patch
Comment on attachment 371883 [details] Patch Clearing flags on attachment: 371883 Committed r246342: <https://trac.webkit.org/changeset/246342> |