Bug 198759
| Summary: | imported/blink/svg/as-image/svgview-references.html is failing in WK1 | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> |
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED WORKSFORME | ||
| Severity: | Normal | CC: | ap, bfulgham, sabouhallawa, simon.fraser, webkit-bot-watchers-bugzilla, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=198677 | ||
youenn fablet
imported/blink/svg/as-image/svgview-references.html is failing in WK1
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/51628929>
Radar WebKit Bug Importer
<rdar://problem/51628931>
youenn fablet
As can be seen in https://bugs.webkit.org/show_bug.cgi?id=198677, the same 1 pixel off issue also happens with cached-svg-image-with-css-cross-domain.html and svg-image-with-css-cross-domain.html when rendering circles, though square works.
Since these two tests used to pass, this is probably a WK1 regression.
Alexey Proskuryakov
What do we know about when these regressed?
Said Abou-Hallawa
There is a <path> element in the svglogo-viewbox.svg image. It has two arcs to draw one bar in the SVG logo.
This image is scaled up in svgview-references.html twice because the viewBox of the referencing <use> element is set to 1/4 and 1/9 of the original image viewBox.
This can make the test fails on some configurations or hardware due to the scaling issue. The fix would be to use other drawing which does not involve arcs or circles. The purpose of this test is to test the SVG image works with viewBox linking correctly. And it does not matter what drawing elements are used.
Said Abou-Hallawa
I can’t reproduce the failure locally. And I did not see the test is skipped in any TestExpectations file. The history of this test shows that it has been passing for long time.
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=imported%2Fblink%2Fsvg%2Fas-image%2Fsvgview-references.html