Bug 198736

Summary: [iOS] Idempotent text autosizing needs to react properly to viewport changes
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: WebKit2Assignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, commit-queue, jonlee, koivisto, mmaxfield, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 198763    
Attachments:
Description Flags
Patch none

Wenson Hsieh
Reported 2019-06-10 17:43:42 PDT
<rdar://problem/50591911>
Attachments
Patch (17.18 KB, patch)
2019-06-11 09:48 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2019-06-11 09:48:13 PDT
Created attachment 371849 [details] Patch
alan
Comment 2 2019-06-11 21:19:48 PDT
Comment on attachment 371849 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371849&action=review > Source/WebCore/css/StyleResolver.cpp:901 > + if (!settings().textAutosizingEnabled() || !settings().textAutosizingUsesIdempotentMode()) > + return; > + > + if (!hasTextChildren(element)) > + return; > + > + if (style.textSizeAdjust().isNone()) > + return; > + > + if (newAutosizeStatus.shouldSkipSubtree()) > + return; > + so much better
Wenson Hsieh
Comment 3 2019-06-11 21:21:33 PDT
Comment on attachment 371849 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371849&action=review >> Source/WebCore/css/StyleResolver.cpp:901 >> + > > so much better 👍🏻
WebKit Commit Bot
Comment 4 2019-06-11 21:51:15 PDT
Comment on attachment 371849 [details] Patch Clearing flags on attachment: 371849 Committed r246348: <https://trac.webkit.org/changeset/246348>
WebKit Commit Bot
Comment 5 2019-06-11 21:51:17 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.