Bug 198736 - [iOS] Idempotent text autosizing needs to react properly to viewport changes
Summary: [iOS] Idempotent text autosizing needs to react properly to viewport changes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks: 198763
  Show dependency treegraph
 
Reported: 2019-06-10 17:43 PDT by Wenson Hsieh
Modified: 2019-06-11 21:51 PDT (History)
7 users (show)

See Also:


Attachments
Patch (17.18 KB, patch)
2019-06-11 09:48 PDT, Wenson Hsieh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2019-06-10 17:43:42 PDT
<rdar://problem/50591911>
Comment 1 Wenson Hsieh 2019-06-11 09:48:13 PDT
Created attachment 371849 [details]
Patch
Comment 2 zalan 2019-06-11 21:19:48 PDT
Comment on attachment 371849 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371849&action=review

> Source/WebCore/css/StyleResolver.cpp:901
> +    if (!settings().textAutosizingEnabled() || !settings().textAutosizingUsesIdempotentMode())
> +        return;
> +
> +    if (!hasTextChildren(element))
> +        return;
> +
> +    if (style.textSizeAdjust().isNone())
> +        return;
> +
> +    if (newAutosizeStatus.shouldSkipSubtree())
> +        return;
> +

so much better
Comment 3 Wenson Hsieh 2019-06-11 21:21:33 PDT
Comment on attachment 371849 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371849&action=review

>> Source/WebCore/css/StyleResolver.cpp:901
>> +
> 
> so much better

👍🏻
Comment 4 WebKit Commit Bot 2019-06-11 21:51:15 PDT
Comment on attachment 371849 [details]
Patch

Clearing flags on attachment: 371849

Committed r246348: <https://trac.webkit.org/changeset/246348>
Comment 5 WebKit Commit Bot 2019-06-11 21:51:17 PDT
All reviewed patches have been landed.  Closing bug.