Bug 198735

Summary:

Quotes are always inserted as smart quotes on stackblitz.com, causing compilation errors

Product:

WebKit

Reporter:

Wenson Hsieh <wenson_hsieh>

Component:

HTML Editing

Assignee:

Wenson Hsieh <wenson_hsieh>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, commit-queue, megan_gardner, thorton, timothy, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Wenson Hsieh 2019-06-10 17:09:06 PDT

<rdar://problem/51557159>

Comment 1 Wenson Hsieh 2019-06-10 17:10:10 PDT

We should match macOS behavior by disabling smart quotes and dashes if spellcheck="false"

Comment 2 Wenson Hsieh 2019-06-10 17:34:08 PDT

Created attachment 371799 [details]
Patch

Comment 3 Wenson Hsieh 2019-06-11 07:16:52 PDT

Comment on attachment 371799 [details]
Patch

Thanks for the review!

Comment 4 WebKit Commit Bot 2019-06-11 07:46:29 PDT

Comment on attachment 371799 [details]
Patch

Clearing flags on attachment: 371799

Committed r246311: <https://trac.webkit.org/changeset/246311>

Comment 5 WebKit Commit Bot 2019-06-11 07:46:31 PDT

All reviewed patches have been landed.  Closing bug.