Bug 198735 - Quotes are always inserted as smart quotes on stackblitz.com, causing compilation errors
Summary: Quotes are always inserted as smart quotes on stackblitz.com, causing compila...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-06-10 17:09 PDT by Wenson Hsieh
Modified: 2019-06-11 07:46 PDT (History)
7 users (show)

See Also:


Attachments
Patch (8.09 KB, patch)
2019-06-10 17:34 PDT, Wenson Hsieh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2019-06-10 17:09:06 PDT
<rdar://problem/51557159>
Comment 1 Wenson Hsieh 2019-06-10 17:10:10 PDT
We should match macOS behavior by disabling smart quotes and dashes if spellcheck="false"
Comment 2 Wenson Hsieh 2019-06-10 17:34:08 PDT
Created attachment 371799 [details]
Patch
Comment 3 Wenson Hsieh 2019-06-11 07:16:52 PDT
Comment on attachment 371799 [details]
Patch

Thanks for the review!
Comment 4 WebKit Commit Bot 2019-06-11 07:46:29 PDT
Comment on attachment 371799 [details]
Patch

Clearing flags on attachment: 371799

Committed r246311: <https://trac.webkit.org/changeset/246311>
Comment 5 WebKit Commit Bot 2019-06-11 07:46:31 PDT
All reviewed patches have been landed.  Closing bug.