Bug 198734

Summary: [WPE][GTK] bubblewrap sandbox should grant access to web extensions directory
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WebKitGTKAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, bugs-noreply, cgarcia, commit-queue, ews-watchlist, gustavo, mcatanzaro
Priority: P2    
Version: WebKit Nightly Build   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews213 for win-future none

Michael Catanzaro
Reported 2019-06-10 16:24:56 PDT
bubblewrap sandbox should grant access to web extensions directory, or web extensions won't be loadable.
Attachments
Patch (1.33 KB, patch)
2019-06-10 16:26 PDT, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews213 for win-future (13.69 MB, application/zip)
2019-06-10 21:19 PDT, EWS Watchlist 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2019-06-10 16:26:32 PDT
Created attachment 371792 [details] Patch
EWS Watchlist
Comment 2 2019-06-10 16:28:51 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
EWS Watchlist
Comment 3 2019-06-10 21:19:17 PDT
Comment on attachment 371792 [details] Patch Attachment 371792 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12440150 New failing tests: imported/blink/compositing/layer-creation/iframe-clip-removed.html
EWS Watchlist
Comment 4 2019-06-10 21:19:19 PDT
Created attachment 371819 [details] Archive of layout-test-results from ews213 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews213 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
WebKit Commit Bot
Comment 5 2019-06-11 01:01:45 PDT
Comment on attachment 371792 [details] Patch Clearing flags on attachment: 371792 Committed r246305: <https://trac.webkit.org/changeset/246305>
WebKit Commit Bot
Comment 6 2019-06-11 01:01:46 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.