Bug 198717

Summary:

Event region should be set on scrolledContentsLayer if it exists

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

Scrolling

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ews-watchlist, graouts, simon.fraser

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	none
Archive of layout-test-results from ews211 for win-future	none

Antti Koivisto

Reported 2019-06-10 07:35:30 PDT

Event region for overflow:scroll layer does not move correctly during scrolling. This causes us to miscompute touch-actions.

Attachments
patch (10.92 KB, patch) 2019-06-10 07:51 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews211 for win-future (13.65 MB, application/zip) 2019-06-10 11:46 PDT, EWS Watchlist	no flags	Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Antti Koivisto

Comment 1 2019-06-10 07:36:16 PDT

<rdar://problem/51572169>

Antti Koivisto

Comment 2 2019-06-10 07:51:11 PDT

Created attachment 371742 [details] patch

Simon Fraser (smfr)

Comment 3 2019-06-10 10:29:56 PDT

Comment on attachment 371742 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=371742&action=review > LayoutTests/pointerevents/ios/touch-action-region-backing-sharing-expected.txt:-4 > - (deep color 1) Not sure why these changed.

EWS Watchlist

Comment 4 2019-06-10 11:46:22 PDT

Comment on attachment 371742 [details] patch Attachment 371742 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12435063 New failing tests: imported/blink/fast/canvas/canvas-clip-stack-persistence.html storage/indexeddb/index-cursor.html

EWS Watchlist

Comment 5 2019-06-10 11:46:24 PDT

Created attachment 371766 [details] Archive of layout-test-results from ews211 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews211 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

Antoine Quint

Comment 6 2019-06-10 11:52:00 PDT

(In reply to Simon Fraser (smfr) from comment #3) > Comment on attachment 371742 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=371742&action=review > > > LayoutTests/pointerevents/ios/touch-action-region-backing-sharing-expected.txt:-4 > > - (deep color 1) > > Not sure why these changed. I think this might depend on the Simulator device, although maybe not?

Antti Koivisto

Comment 7 2019-06-10 13:15:52 PDT

> I think this might depend on the Simulator device, although maybe not? Looking into this I noticed that pointerevents/ios tests are not running by default in opensource bots. Is there some reason for that?

Simon Fraser (smfr)

Comment 8 2019-06-10 13:22:58 PDT

(In reply to Antti Koivisto from comment #7) > > I think this might depend on the Simulator device, although maybe not? > > Looking into this I noticed that pointerevents/ios tests are not running by > default in opensource bots. Is there some reason for that? Presumably their implementation is tied to touch events.

WebKit Commit Bot

Comment 9 2019-06-10 13:43:24 PDT

Comment on attachment 371742 [details] patch Clearing flags on attachment: 371742 Committed r246278: <https://trac.webkit.org/changeset/246278>

WebKit Commit Bot

Comment 10 2019-06-10 13:43:25 PDT

All reviewed patches have been landed. Closing bug.

Antoine Quint

Comment 11 2019-06-11 00:51:09 PDT

(In reply to Simon Fraser (smfr) from comment #8) > (In reply to Antti Koivisto from comment #7) > > > I think this might depend on the Simulator device, although maybe not? > > > > Looking into this I noticed that pointerevents/ios tests are not running by > > default in opensource bots. Is there some reason for that? > > Presumably their implementation is tied to touch events. That's correct.

Note You need to log in before you can comment on or make changes to this bug.