Bug 198697

Summary:

[LFC][IFC] Add support for vertical-align: top and bottom

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue, ews-watchlist, koivisto, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description zalan 2019-06-08 18:58:22 PDT

in addition to baseline

Comment 1 Radar WebKit Bug Importer 2019-06-08 18:58:44 PDT

<rdar://problem/51556188>

Comment 2 zalan 2019-06-08 19:05:31 PDT

Created attachment 371695 [details]
Patch

Comment 3 EWS Watchlist 2019-06-08 19:06:27 PDT

Attachment 371695 [details] did not pass style-queue:


ERROR: Source/WebCore/layout/inlineformatting/InlineLine.cpp:95:  Missing space before ( in switch(  [whitespace/parens] [5]
ERROR: Source/WebCore/layout/inlineformatting/InlineLine.cpp:290:  Missing space before ( in switch(  [whitespace/parens] [5]
ERROR: Source/WebCore/layout/inlineformatting/InlineLine.cpp:292:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 3 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 4 zalan 2019-06-08 19:07:31 PDT

Created attachment 371696 [details]
Patch

Comment 5 WebKit Commit Bot 2019-06-15 07:03:29 PDT

Comment on attachment 371696 [details]
Patch

Clearing flags on attachment: 371696

Committed r246457: <https://trac.webkit.org/changeset/246457>

Comment 6 WebKit Commit Bot 2019-06-15 07:03:31 PDT

All reviewed patches have been landed.  Closing bug.