| Summary: | Make it possible to mark the value of an SVGProperty as 'Invalid' | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Said Abou-Hallawa <sabouhallawa> | ||||||
| Component: | SVG | Assignee: | Said Abou-Hallawa <sabouhallawa> | ||||||
| Status: | NEW --- | ||||||||
| Severity: | Normal | CC: | ahmad.saleem792, ap, bfulgham, ews-watchlist, mmaxfield, rniwa, simon.fraser, webkit-bug-importer, zalan, zimmermann | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Said Abou-Hallawa
2019-06-08 18:37:12 PDT
Created attachment 371692 [details]
Patch
Attachment 371692 [details] did not pass style-queue:
ERROR: Source/WebCore/svg/SVGFETurbulenceElement.h:36: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/svg/SVGFETurbulenceElement.h:37: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/svg/SVGFETurbulenceElement.h:38: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
Total errors found: 3 in 164 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 373847 [details]
Patch for review
I can see that at least on few sample files I looked into that this patch didn't landed because these changes are not done: EXAMPLES: -> These one not: https://github.com/WebKit/WebKit/blob/be8ef74127a13ec30f4a8ce4130eb29a9b55fb30/Source/WebCore/svg/SVGElement.cpp#L645 https://github.com/WebKit/WebKit/blob/0d7afc5a45c140c44497a81e92416f01306be877/Source/WebCore/svg/SVGFitToViewBox.cpp#L39 https://github.com/WebKit/WebKit/blob/0d7afc5a45c140c44497a81e92416f01306be877/Source/WebCore/svg/SVGFitToViewBox.cpp#L52 https://github.com/WebKit/WebKit/blob/0d7afc5a45c140c44497a81e92416f01306be877/Source/WebCore/svg/SVGFitToViewBox.cpp#L58 -> This one is slightly done: https://github.com/WebKit/WebKit/blob/be8ef74127a13ec30f4a8ce4130eb29a9b55fb30/Source/WebCore/svg/SVGElement.cpp#L645 _______ Is this needed or we can mark this as "RESOLVED LATER" or can rebase and land, if it fixes or improves web-compat or performance? Thanks! |