Bug 198695 - Make it possible to mark the value of an SVGProperty as 'Invalid'
Summary: Make it possible to mark the value of an SVGProperty as 'Invalid'
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-06-08 18:37 PDT by Said Abou-Hallawa
Modified: 2019-07-10 10:38 PDT (History)
2 users (show)

See Also:


Attachments
Patch (323.53 KB, patch)
2019-06-08 18:40 PDT, Said Abou-Hallawa
no flags Details | Formatted Diff | Diff
Patch for review (15.81 KB, patch)
2019-07-10 10:38 PDT, Said Abou-Hallawa
sabouhallawa: review?
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2019-06-08 18:37:12 PDT
SVGProperty can be initialized with the default value. Or it can be set to the default value as a fall back of parsing error. Marking the state to 'Invalid' will allow differentiating between these two cases.
Comment 1 Said Abou-Hallawa 2019-06-08 18:40:57 PDT
Created attachment 371692 [details]
Patch
Comment 2 Build Bot 2019-06-08 18:43:27 PDT
Attachment 371692 [details] did not pass style-queue:


ERROR: Source/WebCore/svg/SVGFETurbulenceElement.h:36:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/svg/SVGFETurbulenceElement.h:37:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/svg/SVGFETurbulenceElement.h:38:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 3 in 164 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Said Abou-Hallawa 2019-07-10 10:38:51 PDT
Created attachment 373847 [details]
Patch for review