Bug 198693

Summary: [iOS] The default application name for user agent when requesting desktop content is still "Mobile/15E148"
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: WebKit2Assignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, bdakin, commit-queue, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
thorton: review+
Patch for landing none

Description Wenson Hsieh 2019-06-08 16:18:17 PDT 
...which clearly makes no sense :(
Comment 1 Radar WebKit Bug Importer 2019-06-08 16:45:55 PDT 
<rdar://problem/51555371>
Comment 2 Wenson Hsieh 2019-06-08 17:21:53 PDT 
Created attachment 371686 [details]
Patch
Comment 3 Tim Horton 2019-06-08 17:43:39 PDT 
Comment on attachment 371686 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371686&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:506
> +    return _applicationNameForUserAgent.hasValue() ? _applicationNameForUserAgent->get() : nil;

valueOr?
Comment 4 Wenson Hsieh 2019-06-08 18:40:40 PDT 
Comment on attachment 371686 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371686&action=review

>> Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:506
>> +    return _applicationNameForUserAgent.hasValue() ? _applicationNameForUserAgent->get() : nil;
> 
> valueOr?

Good catch! Will use it here and below (-applicationNameForUserAgent) as well.
Comment 5 Wenson Hsieh 2019-06-08 20:13:02 PDT 
Created attachment 371700 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2019-06-08 20:55:07 PDT 
Comment on attachment 371700 [details]
Patch for landing

Clearing flags on attachment: 371700

Committed r246236: <https://trac.webkit.org/changeset/246236>