Bug 198693

Summary: [iOS] The default application name for user agent when requesting desktop content is still "Mobile/15E148"
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: WebKit2Assignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, bdakin, commit-queue, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
thorton: review+
Patch for landing none

Wenson Hsieh
Reported 2019-06-08 16:18:17 PDT
...which clearly makes no sense :(
Attachments
Patch (22.80 KB, patch)
2019-06-08 17:21 PDT, Wenson Hsieh 		thorton: review+
DetailsFormatted DiffDiff
Patch for landing (22.64 KB, patch)
2019-06-08 20:13 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-06-08 16:45:55 PDT
<rdar://problem/51555371>
Wenson Hsieh
Comment 2 2019-06-08 17:21:53 PDT
Created attachment 371686 [details] Patch
Tim Horton
Comment 3 2019-06-08 17:43:39 PDT
Comment on attachment 371686 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371686&action=review > Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:506 > + return _applicationNameForUserAgent.hasValue() ? _applicationNameForUserAgent->get() : nil; valueOr?
Wenson Hsieh
Comment 4 2019-06-08 18:40:40 PDT
Comment on attachment 371686 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371686&action=review >> Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:506 >> + return _applicationNameForUserAgent.hasValue() ? _applicationNameForUserAgent->get() : nil; > > valueOr? Good catch! Will use it here and below (-applicationNameForUserAgent) as well.
Wenson Hsieh
Comment 5 2019-06-08 20:13:02 PDT
Created attachment 371700 [details] Patch for landing
WebKit Commit Bot
Comment 6 2019-06-08 20:55:07 PDT
Comment on attachment 371700 [details] Patch for landing Clearing flags on attachment: 371700 Committed r246236: <https://trac.webkit.org/changeset/246236>
Note You need to log in before you can comment on or make changes to this bug.