Bug 198693 - [iOS] The default application name for user agent when requesting desktop content is still "Mobile/15E148"
Summary: [iOS] The default application name for user agent when requesting desktop con...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-06-08 16:18 PDT by Wenson Hsieh
Modified: 2019-06-08 20:58 PDT (History)
5 users (show)

See Also:

Attachments
Patch (22.80 KB, patch)
2019-06-08 17:21 PDT, Wenson Hsieh 		thorton: review+
Details | Formatted Diff | Diff
Patch for landing (22.64 KB, patch)
2019-06-08 20:13 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2019-06-08 16:18:17 PDT 
...which clearly makes no sense :(
Comment 1 Radar WebKit Bug Importer 2019-06-08 16:45:55 PDT 
<rdar://problem/51555371>
Comment 2 Wenson Hsieh 2019-06-08 17:21:53 PDT 
Created attachment 371686 [details]
Patch
Comment 3 Tim Horton 2019-06-08 17:43:39 PDT 
Comment on attachment 371686 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371686&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:506
> +    return _applicationNameForUserAgent.hasValue() ? _applicationNameForUserAgent->get() : nil;

valueOr?
Comment 4 Wenson Hsieh 2019-06-08 18:40:40 PDT 
Comment on attachment 371686 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371686&action=review

>> Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:506
>> +    return _applicationNameForUserAgent.hasValue() ? _applicationNameForUserAgent->get() : nil;
> 
> valueOr?

Good catch! Will use it here and below (-applicationNameForUserAgent) as well.
Comment 5 Wenson Hsieh 2019-06-08 20:13:02 PDT 
Created attachment 371700 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2019-06-08 20:55:07 PDT 
Comment on attachment 371700 [details]
Patch for landing

Clearing flags on attachment: 371700

Committed r246236: <https://trac.webkit.org/changeset/246236>