Summary: | [LFC][IFC] Make baselines alignment explicit in Line | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | zalan <zalan> | ||||
Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bfulgham, commit-queue, koivisto, sam, simon.fraser, webkit-bug-importer, zalan | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
zalan
2019-06-07 21:02:53 PDT
Created attachment 371646 [details]
Patch
Comment on attachment 371646 [details] Patch Clearing flags on attachment: 371646 Committed r246234: <https://trac.webkit.org/changeset/246234> All reviewed patches have been landed. Closing bug. Comment on attachment 371646 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371646&action=review > Source/WebCore/layout/inlineformatting/InlineFormattingContextLineLayout.cpp:314 > - auto lineBox = Display::Rect { lineContent.logicalTop(), lineContent.logicalLeft(), 0 , !lineContent.isVisuallyEmpty() ? lineContent.logicalHeight() : LayoutUnit { } }; > + auto lineBox = Display::Rect { lineContent.logicalTop(), lineContent.logicalLeft(), 0, !lineContent.isVisuallyEmpty() ? lineContent.logicalHeight() : LayoutUnit { } }; Minor nit, but it's a bit confusing to call this variable lineBox, now that a LineBox contains more than just the line box rect. Maybe lineBoxRect? (In reply to Sam Weinig from comment #5) > Comment on attachment 371646 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=371646&action=review > > > Source/WebCore/layout/inlineformatting/InlineFormattingContextLineLayout.cpp:314 > > - auto lineBox = Display::Rect { lineContent.logicalTop(), lineContent.logicalLeft(), 0 , !lineContent.isVisuallyEmpty() ? lineContent.logicalHeight() : LayoutUnit { } }; > > + auto lineBox = Display::Rect { lineContent.logicalTop(), lineContent.logicalLeft(), 0, !lineContent.isVisuallyEmpty() ? lineContent.logicalHeight() : LayoutUnit { } }; > > Minor nit, but it's a bit confusing to call this variable lineBox, now that > a LineBox contains more than just the line box rect. Maybe lineBoxRect? You are right! I'll take care of it! (In reply to Sam Weinig from comment #5) > Comment on attachment 371646 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=371646&action=review > > > Source/WebCore/layout/inlineformatting/InlineFormattingContextLineLayout.cpp:314 > > - auto lineBox = Display::Rect { lineContent.logicalTop(), lineContent.logicalLeft(), 0 , !lineContent.isVisuallyEmpty() ? lineContent.logicalHeight() : LayoutUnit { } }; > > + auto lineBox = Display::Rect { lineContent.logicalTop(), lineContent.logicalLeft(), 0, !lineContent.isVisuallyEmpty() ? lineContent.logicalHeight() : LayoutUnit { } }; > > Minor nit, but it's a bit confusing to call this variable lineBox, now that > a LineBox contains more than just the line box rect. Maybe lineBoxRect? https://trac.webkit.org/changeset/246486 |