Bug 198682

Summary:

import-w3c-tests should respect WEBKIT_OUTPUTDIR

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

Tools / Tests

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ews-watchlist, glenn, jbedard, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

All

OS:

All

See Also:

https://bugs.webkit.org/show_bug.cgi?id=198676

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Daniel Bates

Reported 2019-06-07 15:02:51 PDT

Seen with WebKit r246069. Ran Tools/Scripts/import-w3c-tests yesterday and it checked out the w3c repo into a WebKitBuild directory under my current checkout, but this is *not* the WebKitBuild directory I use. All of our other tools know to respect the environment variable WEBKIT_OUTPUTDIR. We should make import-w3c-tests smarter. Steps to reproduce: 1. export WEBKIT_OUTPUTDIR="/tmp/Blah" 2. mkdir -p $WEBKIT_OUTPUTDIR 3. Tools/Scripts/import-w3c-tests -t web-platform-tests/content-security-policy Then the Web Platform Tests checkout should be in /tmp/Blah/w3c-tests, but it is not.

Attachments
Patch (4.61 KB, patch) 2019-06-11 11:46 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (4.44 KB, patch) 2019-06-11 12:11 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (6.11 KB, patch) 2019-06-12 10:36 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.