Bug 198678

Summary: Add a quirk for washingtonpost.com and nytimes.com
Product: WebKit Reporter: Sihui Liu <sihui_liu>
Component: New BugsAssignee: Sihui Liu <sihui_liu>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ggaren, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Sihui Liu
Reported 2019-06-07 14:10:08 PDT
Similar to https://bugs.webkit.org/show_bug.cgi?id=195155. Enable WebSQL for these sites for now.
Attachments
Patch (1.46 KB, patch)
2019-06-07 14:11 PDT, Sihui Liu 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sihui Liu
Comment 1 2019-06-07 14:11:40 PDT
Created attachment 371609 [details] Patch
Geoffrey Garen
Comment 2 2019-06-10 14:21:50 PDT
Comment on attachment 371609 [details] Patch r=me Given that this is more than just one site now, I think we need a follow-up bug to reduce the scope and impact of this quirk. Specifically, I'd recommend the following behavior: If we're on a site where this quirk is enabled, make available a global function named openDatabase. If the function is called with four arguments, and all arguments are null, then return an empty object. Otherwise, throw an exception that says "WebSQL is not enabled".
WebKit Commit Bot
Comment 3 2019-06-11 09:26:35 PDT
Comment on attachment 371609 [details] Patch Clearing flags on attachment: 371609 Committed r246319: <https://trac.webkit.org/changeset/246319>
WebKit Commit Bot
Comment 4 2019-06-11 09:26:36 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2019-06-11 09:27:17 PDT
<rdar://problem/51626476>
Note You need to log in before you can comment on or make changes to this bug.