Bug 198677

Summary: Update cached-svg-image-with-css-cross-domain.html and svg-image-with-css-cross-domain.html to use square instead of circle
Product: WebKit Reporter: youenn fablet <youennf>
Component: Tools / TestsAssignee: youenn fablet <youennf>
Status: RESOLVED CONFIGURATION CHANGED    
Severity: Normal CC: ap, ryanhaddad, sabouhallawa, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=198759
Attachments:
Description Flags
Patch none

youenn fablet
Reported 2019-06-07 13:55:35 PDT
This helps WK1.
Attachments
Patch (13.54 KB, patch)
2019-06-07 13:57 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2019-06-07 13:57:22 PDT
Created attachment 371608 [details] Patch
youenn fablet
Comment 2 2019-06-07 14:04:54 PDT
<rdar://problem/51229282>
Alexey Proskuryakov
Comment 3 2019-06-07 16:59:16 PDT
Circles should cause issues either, if drawn in the same way. What is the state that is different?
youenn fablet
Comment 4 2019-06-10 08:35:32 PDT
(In reply to Alexey Proskuryakov from comment #3) > Circles should cause issues either, if drawn in the same way. What is the > state that is different? Agreed that this should work with circles as it used to do and is probably a regression in WK1 rendering. Given the purpose of those two tests is not about rendering, fixing it this way ensures we do not regress the parts of WK1 implementation that these tests were written for.
Alexey Proskuryakov
Comment 5 2019-06-10 23:55:29 PDT
Makes sense. Can you file a bug about the rendering regression? I'm not quite sure about the details here (is it reproducible? are we confident that it's a regression?)
Ryan Haddad
Comment 6 2019-09-09 17:46:43 PDT
These tests are passing now, marking as resolved.
Note You need to log in before you can comment on or make changes to this bug.