Summary: | [iOS] At least 6 API tests are failing due to an exception when writing NSAttributedString to the pasteboard | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Wenson Hsieh <wenson_hsieh> | ||||||
Component: | Tools / Tests | Assignee: | Wenson Hsieh <wenson_hsieh> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bdakin, commit-queue, megan_gardner, ryanhaddad, thorton, timothy, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Wenson Hsieh
2019-06-06 20:39:48 PDT
They are: --- WKAttachmentTests.CopyAndPasteBetweenWebViews WKAttachmentTests.InsertPastedAttributedStringContainingMultipleAttachments WKAttachmentTests.InsertPastedAttributedStringContainingImage WKWebViewEditActions.PasteAsQuotation WKWebViewEditActions.PasteAndMatchStyle UIPasteboardTests.CopyRichTextWritesConcreteTypes Created attachment 371558 [details]
Patch
Created attachment 371559 [details]
Fix open source build
Comment on attachment 371559 [details] Fix open source build View in context: https://bugs.webkit.org/attachment.cgi?id=371559&action=review > Tools/TestWebKitAPI/cocoa/TestWKWebView.mm:291 > + swizzler = std::make_unique<ClassMethodSwizzler>(NSAttributedString.class, @selector(writableTypeIdentifiersForItemProvider), reinterpret_cast<IMP>(writableTypeIdentifiersForItemProviderWithoutPublicRTFD)); 🤨 Comment on attachment 371559 [details] Fix open source build View in context: https://bugs.webkit.org/attachment.cgi?id=371559&action=review >> Tools/TestWebKitAPI/cocoa/TestWKWebView.mm:291 >> + swizzler = std::make_unique<ClassMethodSwizzler>(NSAttributedString.class, @selector(writableTypeIdentifiersForItemProvider), reinterpret_cast<IMP>(writableTypeIdentifiersForItemProviderWithoutPublicRTFD)); > > 🤨 🤷🏻♂️ Comment on attachment 371559 [details] Fix open source build Clearing flags on attachment: 371559 Committed r246198: <https://trac.webkit.org/changeset/246198> All reviewed patches have been landed. Closing bug. |