Bug 19864

Summary: Computed style for webkitTransform property
Product: WebKit Reporter: Dean Jackson <dino>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: All   
Bug Depends on: 19863    
Bug Blocks: 19028    
Attachments:
Description Flags
implements computed style for webkit-transform prop
hyatt: review+
testcase for computed style of transforms none

Dean Jackson
Reported 2008-07-02 19:17:41 PDT
The computed style for the -webkit-transform property is not implemented.
Attachments
implements computed style for webkit-transform prop (4.20 KB, patch)
2008-07-02 19:18 PDT, Dean Jackson
hyatt: review+
testcase for computed style of transforms (1.62 KB, text/html)
2008-07-02 19:19 PDT, Dean Jackson
no flags
Dean Jackson
Comment 1 2008-07-02 19:18:43 PDT
Created attachment 22058 [details] implements computed style for webkit-transform prop
Dean Jackson
Comment 2 2008-07-02 19:19:20 PDT
Created attachment 22059 [details] testcase for computed style of transforms
Simon Fraser (smfr)
Comment 3 2008-07-07 20:26:27 PDT
This change: WebKitCSSTransformValue::WebKitCSSTransformValue(TransformOperationType op) - : CSSValueList(false) + : CSSValueList(true) , m_type(op) { } is showing up in several of your patches.
Dave Hyatt
Comment 4 2008-07-08 11:15:44 PDT
Comment on attachment 22058 [details] implements computed style for webkit-transform prop r=me, please land a layout test with this change though, as it should be possible to make a text-only layout test for this.
Dean Jackson
Comment 5 2008-07-08 15:11:27 PDT
Simon, it's redoing the undo of the redo of that change :) either way, i'll make sure only the correct change gets submitted - once. and yeah, will add a layout test
Dean Jackson
Comment 6 2008-07-10 21:54:23 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog A LayoutTests/css3/transform-computed-style-001-expected.txt A LayoutTests/css3/transform-computed-style-001.html M WebCore/ChangeLog M WebCore/css/CSSComputedStyleDeclaration.cpp A WebCore/manual-tests/computed-transform-value.html Committed r35117
Note You need to log in before you can comment on or make changes to this bug.