Bug 198639

Summary: Web Inspector: Timelines: only complete Composite records if the m_startedComposite (followup to r246142)
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Severity: Normal CC: commit-queue, ews-watchlist, hi, inspector-bugzilla-changes, joepeck, mattbaker, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 198497    
Bug Blocks:    
Description Flags
Patch none

Description Devin Rousso 2019-06-06 19:03:44 PDT
In r246142, an `ASSERT` was removed because it is possible for Web Inspector to be opened in between `willComposite` and `didComposite`, meaning that previously the `ASSERT` would fire.  In order to properly handle this, we should replace the `ASSERT` with an `if` so that we don't even try to complete a `Composite` record if Web Inspector is opened in that case.
Comment 1 Devin Rousso 2019-06-06 19:04:55 PDT
Created attachment 371549 [details]
Comment 2 Matt Baker 2019-06-06 20:07:12 PDT
Comment on attachment 371549 [details]

Comment 3 WebKit Commit Bot 2019-06-06 20:38:28 PDT
Comment on attachment 371549 [details]

Clearing flags on attachment: 371549

Committed r246186: <https://trac.webkit.org/changeset/246186>
Comment 4 WebKit Commit Bot 2019-06-06 20:38:30 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-06-06 20:39:15 PDT