Bug 198620

Summary: [lldb-webkit] Pretty-print all kinds of Documents
Product: WebKit Reporter: Daniel Bates <dbates>
Component: Tools / TestsAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, dino, jer.noble, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Daniel Bates
Reported 2019-06-06 12:18:40 PDT
We need to add a formatter for each Document derived class in order for LLDB to pretty-print it. Otherwise, you have to manually drill down in Xcode- or cast- to Document* in order for LLDB to emit a pretty-printed summary. Let's make things just work™ and add formatting for all the derived classes.
Attachments
Patch (2.55 KB, patch)
2019-06-06 12:23 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2019-06-06 12:23:33 PDT
Created attachment 371519 [details] Patch
Daniel Bates
Comment 2 2019-06-07 15:52:37 PDT
Comment on attachment 371519 [details] Patch Clearing flags on attachment: 371519 Committed r246222: <https://trac.webkit.org/changeset/246222>
Daniel Bates
Comment 3 2019-06-07 15:52:38 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2019-06-07 15:58:26 PDT
<rdar://problem/51539208>
Note You need to log in before you can comment on or make changes to this bug.