Bug 198620

Summary:

[lldb-webkit] Pretty-print all kinds of Documents

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

Tools / Tests

Assignee:

Daniel Bates <dbates>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, dino, jer.noble, simon.fraser, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Description Daniel Bates 2019-06-06 12:18:40 PDT

We need to add a formatter for each Document derived class in order for LLDB to pretty-print it. Otherwise, you have to manually drill down in Xcode- or cast- to Document* in order for LLDB to emit a pretty-printed summary.

Let's make things just work™ and add formatting for all the derived classes.

Comment 1 Daniel Bates 2019-06-06 12:23:33 PDT

Created attachment 371519 [details]
Patch

Comment 2 Daniel Bates 2019-06-07 15:52:37 PDT

Comment on attachment 371519 [details]
Patch

Clearing flags on attachment: 371519

Committed r246222: <https://trac.webkit.org/changeset/246222>

Comment 3 Daniel Bates 2019-06-07 15:52:38 PDT

All reviewed patches have been landed.  Closing bug.

Comment 4 Radar WebKit Bug Importer 2019-06-07 15:58:26 PDT

<rdar://problem/51539208>