Bug 198585 – -[WKWebView _suspendAllMediaPlayback] does not persist across navigation.

• Component: New Bugs
• Status: RESOLVED FIXED

[Jer Noble]

-[WKWebView _suspendAllMediaPlayback] does not persist across navigation.

[Jer Noble]

Created attachment 371442 [details]
Patch

[Alex Christensen]

Comment on attachment 371442 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371442&action=review

> Tools/ChangeLog:12
> +        * TestWebKitAPI/Tests/WebKitLegacy/ios/video-with-audio.html:

We should move this away from the WebKitLegacy directory since it's not just used for WebKitLegacy.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSuspendAllMediaPlayback.mm:60
> +    [webView performAfterReceivingMessage:@"playing" action:^() { isPlaying = true; }];

I think the () is unnecessary.

[Jer Noble]

(In reply to Alex Christensen from comment #2)
> Comment on attachment 371442 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=371442&action=review
> 
> > Tools/ChangeLog:12
> > +        * TestWebKitAPI/Tests/WebKitLegacy/ios/video-with-audio.html:
> 
> We should move this away from the WebKitLegacy directory since it's not just
> used for WebKitLegacy.

There's not really a good general-purpose location for bundle resources. We should totally add one, but that's probably out-of-scope for this patch.

> > Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSuspendAllMediaPlayback.mm:60
> > +    [webView performAfterReceivingMessage:@"playing" action:^() { isPlaying = true; }];
> 
> I think the () is unnecessary.

Will change, in all the places this pattern appears.

[Jer Noble]

Created attachment 371447 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 371447 [details]
Patch for landing

Clearing flags on attachment: 371447

Committed r246136: <https://trac.webkit.org/changeset/246136>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/51464985>