Bug 198582 – TestWebKitAPI.WKWebView.LocalStorageProcessSuspends is flaky on release builds

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Sihui Liu]

Failed

    TestWebKitAPI.WKWebView.LocalStorageProcessSuspends
        _RegisterApplication(), FAILED TO establish the default connection to the WindowServer, _CGSDefaultConnection() is NULL.
        _RegisterApplication(), FAILED TO establish the default connection to the WindowServer, _CGSDefaultConnection() is NULL.

        /Volumes/Data/slave/mojave-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm:142
        Expected equality of these values:
          @"value"
            Which is: "value"
          result
            Which is: "newValue"

[Sihui Liu]

Created attachment 371440 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 371440 [details]
Patch

Clearing flags on attachment: 371440

Committed r246132: <https://trac.webkit.org/changeset/246132>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/51459712>

[Ryosuke Niwa]

Comment on attachment 371440 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371440&action=review

> Source/WebKit/NetworkProcess/WebStorage/StorageManager.h:121
> -    State m_state;
> +    State m_state { State::Running };

We don't enable a warning for uninitialized member variables!?