Summary: | REGRESSION(r243094): [GTK][WPE] Stale content after restoring the web view session | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | berto, bugs-noreply, cdumez, ews-watchlist, gustavo, mcatanzaro | ||||||
Priority: | P2 | Keywords: | Gtk, Regression | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
See Also: |
https://bugs.webkit.org/show_bug.cgi?id=195758 https://bugs.webkit.org/show_bug.cgi?id=153230 |
||||||||
Bug Depends on: | 207908 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Carlos Garcia Campos
2019-06-05 05:08:21 PDT
Created attachment 371389 [details]
Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Comment on attachment 371389 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371389&action=review > Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp:4129 > + getPage(webView).launchInitialProcessIfNecessary(); Can you please add this call at the beginning of WebPageProxy::restoreFromSessionState() instead? It seems like a useful thing to do for all ports. (In reply to Chris Dumez from comment #3) > Comment on attachment 371389 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=371389&action=review > > > Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp:4129 > > + getPage(webView).launchInitialProcessIfNecessary(); > > Can you please add this call at the beginning of > WebPageProxy::restoreFromSessionState() instead? It seems like a useful > thing to do for all ports. Sure, I thought you wanted the opposite, because cocoa based ports always want stale contents after session restore. Created attachment 371476 [details]
Patch
Committed r246188: <https://trac.webkit.org/changeset/246188> |