Bug 198559

Summary:

"display: contents" Content click does not trigger

Product:

WebKit

Reporter:

709922234

Component:

CSS

Assignee:

Antoine Quint <graouts>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, cmarcelo, commit-queue, dbates, esprehn+autocc, ews-watchlist, graouts, kangil.han, koivisto, rniwa, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

Safari 12

Hardware:

iPhone / iPad

OS:

iOS 12

See Also:

https://bugs.webkit.org/show_bug.cgi?id=218923

Attachments:

Description	Flags
Patch	none

Description 709922234 2019-06-05 04:14:03 PDT

https://codepen.io/mantou132/pen/gJyBoz

Click on the text in the page, sometimes without triggering the click event

Comment 1 Alexey Proskuryakov 2019-06-06 10:18:41 PDT

I can reproduce on an iPhone with shipping iOS, taps indeed are recognized inconsistently.

Moreover, on an iPad Pro with iOS 13 beta, they are not recognized as clicks at all.

Comment 2 Radar WebKit Bug Importer 2019-06-06 10:18:51 PDT

<rdar://problem/51488524>

Comment 3 Antoine Quint 2019-06-13 06:38:41 PDT

In WebPage::commitPotentialTap() we bail early because m_potentialTapNode->renderer() is false. It might be that we need to also check whether renderOrDisplayContentsStyle() returns something.

Comment 4 Antoine Quint 2019-06-13 07:21:50 PDT

Created attachment 372052 [details]
Patch

Comment 5 WebKit Commit Bot 2019-06-13 09:05:34 PDT

Comment on attachment 372052 [details]
Patch

Clearing flags on attachment: 372052

Committed r246404: <https://trac.webkit.org/changeset/246404>

Comment 6 WebKit Commit Bot 2019-06-13 09:05:35 PDT

All reviewed patches have been landed.  Closing bug.