Bug 198541

Summary:

[ContentChangeObserver] Gmail text editing controls require two taps

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description zalan 2019-06-04 13:33:15 PDT

<rdar://problem/51375055>

Comment 1 zalan 2019-06-04 14:29:17 PDT

Created attachment 371336 [details]
Patch

Comment 2 Simon Fraser (smfr) 2019-06-04 16:11:05 PDT

Comment on attachment 371336 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371336&action=review

> Source/WebCore/page/ios/ContentChangeObserver.cpp:98
> +        return element.Element::willRespondToMouseClickEvents();

Ugh. Would it be nicer to add an argument to willRespondToMouseClickEvents() saying whether it's for the touch callout?

Comment 3 zalan 2019-06-04 20:46:20 PDT

(In reply to Simon Fraser (smfr) from comment #2)
> Comment on attachment 371336 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=371336&action=review
> 
> > Source/WebCore/page/ios/ContentChangeObserver.cpp:98
> > +        return element.Element::willRespondToMouseClickEvents();
> 
> Ugh. Would it be nicer to add an argument to willRespondToMouseClickEvents()
> saying whether it's for the touch callout?
Let me think about it.

Comment 4 WebKit Commit Bot 2019-06-04 21:15:27 PDT

Comment on attachment 371336 [details]
Patch

Clearing flags on attachment: 371336

Committed r246096: <https://trac.webkit.org/changeset/246096>

Comment 5 WebKit Commit Bot 2019-06-04 21:15:29 PDT

All reviewed patches have been landed.  Closing bug.