Bug 198539

Summary: Fix 64-bit vs 32-bit mismatch in ISOFairPlayStreamingPsshBox.cpp
Product: WebKit Reporter: Keith Rollin <krollin>
Component: WebCore Misc.Assignee: Keith Rollin <krollin>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, jer.noble, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Keith Rollin 2019-06-04 12:54:43 PDT 
Both ISOFairPlayStreamingKeyAssetIdBox and ISOFairPlayStreamingKeyContextBox have Vector<> data members. The parse() members of these classes call Vector<>::resize() on these members. In both cases, the type of the parameter passed is a uint64_t. However, resize() takes a size_t. On some platforms, size_t is a 32-bit value, leading to a compile-time type mismatch error. Fix this by changing the type of the value passed to parse() into a size_t.
Comment 1 Radar WebKit Bug Importer 2019-06-04 12:54:57 PDT 
<rdar://problem/51410358>
Comment 2 Keith Rollin 2019-06-04 13:02:36 PDT 
Created attachment 371322 [details]
Patch
Comment 3 WebKit Commit Bot 2019-06-04 17:40:41 PDT 
Comment on attachment 371322 [details]
Patch

Clearing flags on attachment: 371322

Committed r246092: <https://trac.webkit.org/changeset/246092>
Comment 4 WebKit Commit Bot 2019-06-04 17:40:43 PDT 
All reviewed patches have been landed.  Closing bug.