Bug 198488

Summary:

[iOS] Do not prevent app suspension for more than 20 seconds after getting backgrounded

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

WebKit2

Assignee:

Chris Dumez <cdumez>

Status:

REOPENED

Severity:

Normal

CC:

commit-queue, ews-watchlist, ggaren, jer.noble, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews105 for mac-highsierra-wk2	none
Patch	none
Patch	none

Chris Dumez

Reported 2019-06-03 10:35:33 PDT

Do not prevent app suspension for more than 20 seconds after getting backgrounded on iOS. We do this by implementing our own expiration handler which notifies our child processes of their imminent suspension before ending the background task that was preventing suspension.

Attachments
Patch (8.47 KB, patch) 2019-06-03 10:39 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews105 for mac-highsierra-wk2 (2.80 MB, application/zip) 2019-06-03 11:53 PDT, EWS Watchlist	no flags	Details
Patch (10.03 KB, patch) 2019-06-03 16:20 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (11.43 KB, patch) 2019-06-03 16:46 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2019-06-03 10:36:12 PDT

<rdar://problem/50837208>

Chris Dumez

Comment 2 2019-06-03 10:39:30 PDT

Created attachment 371194 [details] Patch

EWS Watchlist

Comment 3 2019-06-03 11:53:08 PDT

Comment on attachment 371194 [details] Patch Attachment 371194 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/12364580 New failing tests: http/wpt/service-workers/service-worker-networkprocess-crash.html

EWS Watchlist

Comment 4 2019-06-03 11:53:09 PDT

Created attachment 371201 [details] Archive of layout-test-results from ews105 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6

Geoffrey Garen

Comment 5 2019-06-03 16:11:15 PDT

Comment on attachment 371194 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371194&action=review r=me > Source/WebKit/UIProcess/ios/ProcessAssertionIOS.mm:236 > + [self _cancelPendingReleaseTask]; > + [self _cancelTimeoutTask]; Naming inconsistency is a little annoying here. I think the right naming is probabaly _cancelPendingReleaseTask => _cancelReleaseTask _pendingReleaseTask => _releaseTask _pendingTimeoutTask => _timeoutTask

Chris Dumez

Comment 6 2019-06-03 16:20:53 PDT

Created attachment 371227 [details] Patch

Chris Dumez

Comment 7 2019-06-03 16:46:20 PDT

Created attachment 371230 [details] Patch

Chris Dumez

Comment 8 2019-06-03 18:28:46 PDT

Comment on attachment 371230 [details] Patch Clearing flags on attachment: 371230 Committed r246053: <https://trac.webkit.org/changeset/246053>

Chris Dumez

Comment 9 2019-06-03 18:28:55 PDT

All reviewed patches have been landed. Closing bug.

Jer Noble

Comment 10 2019-07-03 15:00:09 PDT

Rolled out r246053 for reason: This changeset caused media playback when the hosting application is backgrounded to break. Committed r247109: <https://trac.webkit.org/changeset/247109/webkit>

Ryosuke Niwa

Comment 11 2019-08-22 16:58:48 PDT

Was this ever fixed some other way?

Note You need to log in before you can comment on or make changes to this bug.