Bug 198483

Summary:

Use std::hypot() where possible

Product:

WebKit

Reporter:

Zan Dobersek <zan>

Component:

New Bugs

Assignee:

Zan Dobersek <zan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cgarcia, dino, eric.carlson, esprehn+autocc, ews-watchlist, fmalita, glenn, gyuyoung.kim, jer.noble, kondapallykalyan, macpherson, menard, pdr, philipj, sabouhallawa, schenney, sergio, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
WIP	none
WIP	none
WIP	none
Archive of layout-test-results from ews211 for win-future	none
WIP	none
WIP	none
Patch	none
Patch for landing	none
Patch for landing	none

Zan Dobersek

Reported 2019-06-03 07:02:31 PDT

Use std::hypot() where possible

Attachments
WIP (27.17 KB, patch) 2019-06-03 07:03 PDT, Zan Dobersek	no flags	Details Formatted Diff Diff
WIP (27.50 KB, patch) 2019-06-04 01:04 PDT, Zan Dobersek	no flags	Details Formatted Diff Diff
WIP (27.87 KB, patch) 2019-06-04 03:00 PDT, Zan Dobersek	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews211 for win-future (13.82 MB, application/zip) 2019-06-04 06:51 PDT, EWS Watchlist	no flags	Details
WIP (27.84 KB, patch) 2019-06-16 12:37 PDT, Zan Dobersek	no flags	Details Formatted Diff Diff
WIP (28.54 KB, patch) 2019-09-23 05:58 PDT, Zan Dobersek	no flags	Details Formatted Diff Diff
Patch (29.02 KB, patch) 2019-09-24 03:34 PDT, Zan Dobersek	no flags	Details Formatted Diff Diff
Patch for landing (28.99 KB, patch) 2019-10-04 00:55 PDT, Zan Dobersek	no flags	Details Formatted Diff Diff
Patch for landing (29.03 KB, patch) 2020-02-03 01:14 PST, Zan Dobersek	no flags	Details Formatted Diff Diff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.

Zan Dobersek

Comment 1 2019-06-03 07:03:49 PDT

Created attachment 371188 [details] WIP

EWS Watchlist

Comment 2 2019-06-03 07:06:32 PDT

Attachment 371188 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/cairo/PathCairo.cpp:245: p1p0_length is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/graphics/cairo/PathCairo.cpp:246: p1p2_length is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/graphics/cairo/PathCairo.cpp:268: orth_p1p0_length is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 4 in 27 files If any of these errors are false positives, please file a bug against check-webkit-style.

Zan Dobersek

Comment 3 2019-06-04 01:04:33 PDT

Created attachment 371253 [details] WIP

EWS Watchlist

Comment 4 2019-06-04 01:07:28 PDT

Attachment 371253 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/cairo/PathCairo.cpp:245: p1p0_length is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/graphics/cairo/PathCairo.cpp:246: p1p2_length is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/graphics/cairo/PathCairo.cpp:268: orth_p1p0_length is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 4 in 27 files If any of these errors are false positives, please file a bug against check-webkit-style.

Zan Dobersek

Comment 5 2019-06-04 03:00:28 PDT

Created attachment 371261 [details] WIP

EWS Watchlist

Comment 6 2019-06-04 03:03:21 PDT

Attachment 371261 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/cairo/PathCairo.cpp:245: p1p0_length is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/graphics/cairo/PathCairo.cpp:246: p1p2_length is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/graphics/cairo/PathCairo.cpp:268: orth_p1p0_length is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 4 in 27 files If any of these errors are false positives, please file a bug against check-webkit-style.

EWS Watchlist

Comment 7 2019-06-04 06:51:49 PDT

Comment on attachment 371261 [details] WIP Attachment 371261 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12371939 New failing tests: imported/blink/compositing/layer-creation/iframe-clip-removed.html

EWS Watchlist

Comment 8 2019-06-04 06:51:52 PDT

Created attachment 371274 [details] Archive of layout-test-results from ews211 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews211 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

Zan Dobersek

Comment 9 2019-06-16 12:37:42 PDT

Created attachment 372226 [details] WIP

Zan Dobersek

Comment 10 2019-09-23 05:58:54 PDT

Created attachment 379364 [details] WIP

Zan Dobersek

Comment 11 2019-09-24 03:34:25 PDT

Created attachment 379442 [details] Patch

Zan Dobersek

Comment 12 2019-10-04 00:55:32 PDT

Created attachment 380193 [details] Patch for landing

Zan Dobersek

Comment 13 2020-02-03 01:14:24 PST

Created attachment 389496 [details] Patch for landing

Zan Dobersek

Comment 14 2020-02-03 06:14:32 PST

Comment on attachment 389496 [details] Patch for landing Clearing flags on attachment: 389496 Committed r255559: <https://trac.webkit.org/changeset/255559>

Zan Dobersek

Comment 15 2020-02-03 06:14:36 PST

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 16 2020-02-03 06:15:19 PST

<rdar://problem/59108473>

Note You need to log in before you can comment on or make changes to this bug.