| Summary: | Web Inspector: Canvas: split recording tests into separate files so they don't timeout | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||||
| Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, ews-watchlist, hi, inspector-bugzilla-changes, joepeck, tsavell, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=175662 https://bugs.webkit.org/show_bug.cgi?id=207154 |
||||||||
| Attachments: |
|
||||||||
|
Description
Devin Rousso
2019-06-01 12:11:30 PDT
Created attachment 371120 [details]
Patch
Attachment 371120 [details] did not pass style-queue:
ERROR: LayoutTests/platform/gtk/TestExpectations:2202: Path does not exist. [test/expectations] [5]
ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/gtk/TestExpectations:2202: Path does not exist. [test/expectations] [5]
Total errors found: 2 in 42 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 371120 [details]
Patch
rs=me
Created attachment 371121 [details]
Patch
Comment on attachment 371121 [details] Patch Clearing flags on attachment: 371121 Committed r246016: <https://trac.webkit.org/changeset/246016> All reviewed patches have been landed. Closing bug. These two new tests are timing out on only High Sierra Debug WK1 inspector/canvas/recording-2d-full.html inspector/canvas/recording-webgl-full.html History: http://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=inspector%2Fcanvas%2Frecording-2d-full.html%20inspector%2Fcanvas%2Frecording-webgl-full.html (In reply to Truitt Savell from comment #8) > These two new tests are timing out on only High Sierra Debug WK1 > > inspector/canvas/recording-2d-full.html > inspector/canvas/recording-webgl-full.html > > History: > http://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=inspector%2Fcanvas%2Frecording-2d-full.html%20inspector%2Fcanvas%2Frecording-webgl-full.html This is really weird. The latest timeout seems to suggest that the test is working exactly as expected, but get's cut off before it's had a chance to print everything. Is there a way to make the timeout longer? If the test usually completes at around 29 seconds with a chance of hitting 30 seconds then we can mark the test as slow which will give it a much longer timeout time. I marked the tests as slow in r246106 to see if this will help |