Bug 198457

Summary:

Web Inspector: Canvas: in tests don't manually stop recording if a frame count is specified

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Description Devin Rousso 2019-06-01 11:23:23 PDT

If a `frameCount` is specified, the recording will stop by itself, so if we hit the `LastFrame`, there's no need to manually stop the recording at that point.

Comment 1 Devin Rousso 2019-06-01 11:23:49 PDT

<rdar://problem/48248697>

Comment 2 Devin Rousso 2019-06-01 11:30:51 PDT

Created attachment 371116 [details]
Patch

Comment 3 Joseph Pecoraro 2019-06-01 11:35:05 PDT

Comment on attachment 371116 [details]
Patch

r=me

Comment 4 WebKit Commit Bot 2019-06-01 13:19:24 PDT

Comment on attachment 371116 [details]
Patch

Clearing flags on attachment: 371116

Committed r246015: <https://trac.webkit.org/changeset/246015>

Comment 5 WebKit Commit Bot 2019-06-01 13:19:26 PDT

All reviewed patches have been landed.  Closing bug.