Bug 198457 - Web Inspector: Canvas: in tests don't manually stop recording if a frame count is specified
Summary: Web Inspector: Canvas: in tests don't manually stop recording if a frame coun...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-06-01 11:23 PDT by Devin Rousso
Modified: 2019-06-01 13:19 PDT (History)
5 users (show)

See Also:

Attachments
Patch (3.67 KB, patch)
2019-06-01 11:30 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-06-01 11:23:23 PDT 
If a `frameCount` is specified, the recording will stop by itself, so if we hit the `LastFrame`, there's no need to manually stop the recording at that point.
Comment 1 Devin Rousso 2019-06-01 11:23:49 PDT 
<rdar://problem/48248697>
Comment 2 Devin Rousso 2019-06-01 11:30:51 PDT 
Created attachment 371116 [details]
Patch
Comment 3 Joseph Pecoraro 2019-06-01 11:35:05 PDT 
Comment on attachment 371116 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2019-06-01 13:19:24 PDT 
Comment on attachment 371116 [details]
Patch

Clearing flags on attachment: 371116

Committed r246015: <https://trac.webkit.org/changeset/246015>
Comment 5 WebKit Commit Bot 2019-06-01 13:19:26 PDT 
All reviewed patches have been landed.  Closing bug.