Bug 198422

Summary:

WebKitTestRunner sometimes freezes under -[NSWindow release]

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

Tools / Tests

Assignee:

Alexey Proskuryakov <ap>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

beidson, commit-queue, ryanhaddad, sroberts, thorton

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed fix	none

Description Alexey Proskuryakov 2019-05-31 09:47:10 PDT

rdar://problem/50948871

NSWindow does some interesting things when a window that's being deallocated is still the key window. Our code for key window management that was added for gamepad testing makes it so that the window remains the key one until after dealloc, which results in a deadlock.

Comment 1 Alexey Proskuryakov 2019-05-31 09:51:25 PDT

Created attachment 371065 [details]
proposed fix

Comment 2 WebKit Commit Bot 2019-05-31 11:56:42 PDT

Comment on attachment 371065 [details]
proposed fix

Clearing flags on attachment: 371065

Committed r245975: <https://trac.webkit.org/changeset/245975>

Comment 3 WebKit Commit Bot 2019-05-31 11:56:43 PDT

All reviewed patches have been landed.  Closing bug.