Summary: | [ews-app] Add authentication while fetching bugs | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||||||
Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | aakash_jain, ap, jbedard, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | Other | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Aakash Jain
2019-05-31 04:47:37 PDT
Created attachment 371052 [details]
WIP
Created attachment 371288 [details]
Patch
Comment on attachment 371288 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371288&action=review > Tools/BuildSlaveSupport/ews-app/ews/common/bugzilla.py:110 > + if self.authenticated: This code concerns me. What happens if we authenticate, and then this class sticks around for too long, and bugzilla logs us out? If that happens, we have no recourse. I would think that we would set authenticated to false at the beginning on this function. > Tools/BuildSlaveSupport/ews-app/ews/common/bugzilla.py:136 > + if attempts < 5: Can we do: if attempts >= 5: raise Exception(errorMessage) _log.error(errorMessage) time.sleep(5) Comment on attachment 371288 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371288&action=review >> Tools/BuildSlaveSupport/ews-app/ews/common/bugzilla.py:110 >> + if self.authenticated: > > This code concerns me. > > What happens if we authenticate, and then this class sticks around for too long, and bugzilla logs us out? If that happens, we have no recourse. I would think that we would set authenticated to false at the beginning on this function. Agree.. modified to remove caching. >> Tools/BuildSlaveSupport/ews-app/ews/common/bugzilla.py:136 >> + if attempts < 5: > > Can we do: > > if attempts >= 5: > raise Exception(errorMessage) > _log.error(errorMessage) > time.sleep(5) Modified in updated patch. Created attachment 371312 [details]
Patch
Comment on attachment 371312 [details] Patch Clearing flags on attachment: 371312 Committed r246082: <https://trac.webkit.org/changeset/246082> All reviewed patches have been landed. Closing bug. |