Bug 198412

Summary: [iOS] Reveal the focused element when it's immediately above software keyboard
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: HTML EditingAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: megan_gardner, simon.fraser, thorton, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=198244
Attachments:
Description Flags
Fixes the bug none

Ryosuke Niwa
Reported 2019-05-31 01:42:32 PDT
On iPad, we don't force scrolling to reveal the focused element when the element is entirely visible. This can be misleading in cases where there is more content right beneath it relevant for editing operations. Zoom & scroll to reveal the focused element when the said element is right above the software keyboard. <rdar://problem/50633287>
Attachments
Fixes the bug (8.54 KB, patch)
2019-05-31 01:53 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2019-05-31 01:53:14 PDT
Created attachment 371045 [details] Fixes the bug
Wenson Hsieh
Comment 2 2019-05-31 08:01:19 PDT
Comment on attachment 371045 [details] Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=371045&action=review We should double check that this doesn't cause the scroll position to jump in Mail compose when focusing the body field by tapping near the bottom of the compose window. > LayoutTests/fast/scrolling/ios/reveal-focused-element-right-above-keyboard-on-ipad.html:33 > + UIHelper.isIOS = () => true; OOPS! I filed <rdar://problem/51301737> to track this.
Ryosuke Niwa
Comment 3 2019-05-31 16:13:40 PDT
Comment on attachment 371045 [details] Fixes the bug Clearing flags on attachment: 371045 Committed r245993: <https://trac.webkit.org/changeset/245993>
Ryosuke Niwa
Comment 4 2019-05-31 16:13:42 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.