[CMake] Add WebKit::WTF target

• Component: CMake
• Status: RESOLVED FIXED

[Don Olmstead]

Use WEBKIT_FRAMEWORK_TARGET for WTF.

[Don Olmstead]

Created attachment 371011 [details]
Patch

[Konstantin Tokarev]

MiniBrowser failed to build on Win EWS: 

c:\cygwin\home\buildbot\webkit\tools\minibrowser\win\stdafx.h(34): fatal error C1083: Cannot open include file: 'cmakeconfig.h': No such file or directory (compiling source file C:\cygwin\home\buildbot\WebKit\Tools\MiniBrowser\win\WinMain.cpp)

[Don Olmstead]

Created attachment 371055 [details]
Patch

[Konstantin Tokarev]

Comment on attachment 371055 [details]
Patch

r=me if WTF is happy

[Konstantin Tokarev]

Comment on attachment 371055 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371055&action=review

> Source/JavaScriptCore/ChangeLog:3
> +        [CMake] Add WebKit::WTF target

BTW, this commit message is not accurate: you don't add WebKit::WTF target (it was added previously), but use it instead of WTF${DEBUG_SUFFIX}.

[Don Olmstead]

(In reply to Konstantin Tokarev from comment #5)
> Comment on attachment 371055 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=371055&action=review
> 
> > Source/JavaScriptCore/ChangeLog:3
> > +        [CMake] Add WebKit::WTF target
> 
> BTW, this commit message is not accurate: you don't add WebKit::WTF target
> (it was added previously), but use it instead of WTF${DEBUG_SUFFIX}.

There was a patch that added it but it got rolled out

[WebKit Commit Bot]

Comment on attachment 371055 [details]
Patch

Clearing flags on attachment: 371055

Committed r245968: <https://trac.webkit.org/changeset/245968>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.