Bug 198370

Summary: [ews-build] Update configuration to share bots across queues
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, commit-queue, jbedard, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=197571
https://bugs.webkit.org/show_bug.cgi?id=213521
Attachments:
Description Flags
Patch none

Description Aakash Jain 2019-05-30 05:13:25 PDT
Share bots across builder and tester queues in order to increase efficiency of the system. So that when bots are idle on one queue they can process patches on other queues.
Comment 1 Aakash Jain 2019-05-30 05:16:38 PDT
Created attachment 370935 [details]
Patch
Comment 2 Jonathan Bedard 2019-05-30 08:13:01 PDT
Comment on attachment 370935 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370935&action=review

> Tools/ChangeLog:8
> +        * BuildSlaveSupport/ews-build/config.json: Share bots across builder and API tester queues.

Will we eventually do this with layout testers too?

> Tools/ChangeLog:10
> +        noted in https://bugs.webkit.org/show_bug.cgi?id=197571#c1

Can't we just fix the keychain on that bot?
Comment 3 Aakash Jain 2019-05-30 08:50:04 PDT
> Will we eventually do this with layout testers too?
Haven't planned that yet.

> Can't we just fix the keychain on that bot?
Yeah, someone need to debug that further.
Comment 4 WebKit Commit Bot 2019-05-30 09:17:11 PDT
Comment on attachment 370935 [details]
Patch

Clearing flags on attachment: 370935

Committed r245886: <https://trac.webkit.org/changeset/245886>
Comment 5 WebKit Commit Bot 2019-05-30 09:17:12 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-05-30 09:18:16 PDT
<rdar://problem/51263202>
Comment 7 Alexey Proskuryakov 2019-05-30 09:36:33 PDT
I'm not sure about this change. Sharing bots means that long term effects of tests will also be breaking builders now. It was nice to know what was happening on a bot that panicked or froze - e.g issues on a builder are more likely to mean hardware failures. Sharing machines makes maintenance harder.

> > Can't we just fix the keychain on that bot?
> Yeah, someone need to debug that further.

I don't think that there is anything to debug, we just need to erase install it.