Bug 198351

Summary: Clean up a few #include statements in WTF
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: Web Template FrameworkAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, benjamin, cdumez, cmarcelo, commit-queue, dbates, ews-watchlist, fujii.hironori, saam, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=198349
Attachments:
Description Flags
Patch v1 none

David Kilzer (:ddkilzer)
Reported 2019-05-29 14:35:23 PDT
Clean up a few #include statements in WTF. Found using this command from Bug 198349: $ ./Tools/Scripts/check-webkit-style --filter=-,+build/include_order Source/WTF 2>&1 | grep -i primary
Attachments
Patch v1 (2.42 KB, patch)
2019-05-29 14:38 PDT, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2019-05-29 14:37:42 PDT
NOTE: The style bot will report errors until Bug 198349 is fixed.
David Kilzer (:ddkilzer)
Comment 2 2019-05-29 14:38:14 PDT
Created attachment 370885 [details] Patch v1
EWS Watchlist
Comment 3 2019-05-29 14:40:44 PDT
Attachment 370885 [details] did not pass style-queue: ERROR: Source/WTF/wtf/StackBounds.cpp:22: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WTF/wtf/StackBounds.cpp:23: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/ParallelJobsGeneric.cpp:29: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 3 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
David Kilzer (:ddkilzer)
Comment 4 2019-05-29 14:41:43 PDT
Need to wait for WPE/Win builds to complete since Source/WTF/wtf/ParallelJobsGeneric.cpp is only built by those ports.
WebKit Commit Bot
Comment 5 2019-05-29 16:07:36 PDT
Comment on attachment 370885 [details] Patch v1 Clearing flags on attachment: 370885 Committed r245876: <https://trac.webkit.org/changeset/245876>
WebKit Commit Bot
Comment 6 2019-05-29 16:07:37 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-05-29 16:08:16 PDT
<rdar://problem/51241724>
Note You need to log in before you can comment on or make changes to this bug.