Bug 198349

Summary: check-webkit-style reports false-positive build/include_order warning in WTF C++ source files
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: Tools / TestsAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bburg, cgarcia, commit-queue, ews-watchlist, glenn, mcatanzaro, thorton, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=198346
https://bugs.webkit.org/show_bug.cgi?id=198351
Attachments:
Description Flags
Patch v1 none

David Kilzer (:ddkilzer)
Reported 2019-05-29 13:23:21 PDT
check-webkit-style reports false-positive build/include_order warning in WTF C++ source files. For example, see Bug 198346 Comment #3: <https://bugs.webkit.org/show_bug.cgi?id=198346#c3> ERROR: Source/WTF/wtf/CrossThreadTaskHandler.cpp:29: Alphabetical sorting problem. [build/include_order] [4] For this source in Source/WTF/wtf/CrossThreadTaskHandler.cpp: #include "config.h" #include <wtf/CrossThreadTaskHandler.h> #include <wtf/AutodrainedPool.h> For whatever reason, most C++ source files in WTF use <wtf/Header.h> instead of "Header.h".
Attachments
Patch v1 (4.95 KB, patch)
2019-05-29 14:17 PDT, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2019-05-29 14:16:13 PDT
This fix cuts down on a HUGE amount of false-positives about a missing primary header when running this command: $ ./Tools/Scripts/check-webkit-style --filter=-,+build/include_order Source/WTF 2>&1 | grep -i primary
David Kilzer (:ddkilzer)
Comment 2 2019-05-29 14:17:18 PDT
Created attachment 370883 [details] Patch v1
Alex Christensen
Comment 3 2019-05-29 14:37:52 PDT
Comment on attachment 370883 [details] Patch v1 r=me This is necessary so that #pragma once can work with WTF headers, which would otherwise sometimes be included from the build directory and sometimes from the source causing duplicate declarations from including two copies of the same header.
David Kilzer (:ddkilzer)
Comment 4 2019-05-29 14:39:00 PDT
(In reply to Alex Christensen from comment #3) > Comment on attachment 370883 [details] > Patch v1 > > r=me > This is necessary so that #pragma once can work with WTF headers, which > would otherwise sometimes be included from the build directory and sometimes > from the source causing duplicate declarations from including two copies of > the same header. Thanks for the explanation!
WebKit Commit Bot
Comment 5 2019-05-29 15:05:06 PDT
Comment on attachment 370883 [details] Patch v1 Clearing flags on attachment: 370883 Committed r245870: <https://trac.webkit.org/changeset/245870>
WebKit Commit Bot
Comment 6 2019-05-29 15:05:07 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-05-29 15:06:19 PDT
<rdar://problem/51238831>
Note You need to log in before you can comment on or make changes to this bug.