Bug 198345 – Video playback in Safari should continue when CarPlay is plugged in

• Component: New Bugs
• Status: RESOLVED FIXED

[Jer Noble]

Video playback in Safari should continue when CarPlay is plugged in

[Jer Noble]

<rdar://problem/45505750>

[Jer Noble]

Created attachment 370875 [details]
Patch

[Eric Carlson]

Comment on attachment 370875 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370875&action=review

> Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm:213
> +    setIsPlayingToAutomotiveHeadUnit(carPlayIsConnected.value());

Shouldn't this be: setIsPlayingToAutomotiveHeadUnit(carPlayIsConnected && carPlayIsConnected.value())

> Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm:312
> +    callOnWebThreadOrDispatchAsyncOnMainThread([protectedSelf = retainPtr(self)]() mutable {

:-/

> Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm:450
> +        protectedSelf->_callback->carPlayServerDied();

_callback should be NULL-checked, it may have been clear by the time this runs

> Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm:467
> +        protectedSelf->_callback->updateCarPlayIsConnected(WTFMove(carPlayIsConnected));

Ditto.

> LayoutTests/media/video-isplayingtoautomotiveheadunit.html:11
> +		findMediaElement();
> +
> +		run('video.src = findMediaFile("video", "content/test")');

:-O TABS!

[Jer Noble]

Comment on attachment 370875 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370875&action=review

>> Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm:213
>> +    setIsPlayingToAutomotiveHeadUnit(carPlayIsConnected.value());
> 
> Shouldn't this be: setIsPlayingToAutomotiveHeadUnit(carPlayIsConnected && carPlayIsConnected.value())

Yeah, it probably should be (in the case that we can't load the CarPlayIsConnectedAttribute).

>> Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm:450
>> +        protectedSelf->_callback->carPlayServerDied();
> 
> _callback should be NULL-checked, it may have been clear by the time this runs

Will do.

[Jer Noble]

Created attachment 370944 [details]
Patch for landing

[Jer Noble]

Created attachment 370945 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 370945 [details]
Patch for landing

Clearing flags on attachment: 370945

Committed r245887: <https://trac.webkit.org/changeset/245887>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Truitt Savell]

Fixed iOS build in https://trac.webkit.org/changeset/245890/webkit

[Jer Noble]

(In reply to Truitt Savell from comment #9)
> Fixed iOS build in https://trac.webkit.org/changeset/245890/webkit

Thanks Truitt!

[Ryan Haddad]

This change broke internal builds, details in email and radar. 

Reverted in https://trac.webkit.org/r245944

[Jer Noble]

Committed r245947: <https://trac.webkit.org/changeset/245947>